Conversation
e60c90e to
78b7f0a
Compare
78b7f0a to
65246fa
Compare
Member
Author
|
needs some manual work to verify windows gnu and freebsd are happy |
Member
|
Can we agree not to combine reorg with changes? It would have been so much easier to review if they weren't spliced into a single PR. |
65246fa to
1f6c223
Compare
…cc & freebsd happy
1f6c223 to
23ef770
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes:
Some more context:
EchoCancellerwas not implemented on the output side#cfg[]'s and centralized them inecho_canceller.rs