Skip to content

agent_servers: Fix Claude Agent model resetting to default#51587

Merged
Veykril merged 2 commits intozed-industries:mainfrom
OmChillure:fix-claude-agent-model-reset
Mar 16, 2026
Merged

agent_servers: Fix Claude Agent model resetting to default#51587
Veykril merged 2 commits intozed-industries:mainfrom
OmChillure:fix-claude-agent-model-reset

Conversation

@OmChillure
Copy link
Copy Markdown
Contributor

Fixes #51082

Description :

When a user configures default_config_options (e.g. a specific model) for an ACP agent, the setting was only applied when creating a new session. Resuming or loading an existing session (e.g. from history) skipped this step, causing the model dropdown to revert to "Default (recommended)".

Fix :

Extract the config options defaulting logic into a shared helper apply_default_config_options and call it consistently across all three session entry points: new_session, resume_session, and load_session
Release Notes:

Release notes :

Fixed model dropdown resetting to "Default (recommended)" when opening a previous conversation from history. Configured models (via default_config_options) are now correctly applied when resuming or loading existing sessions.

Video :

Screencast.from.2026-03-15.12-55-58.webm

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 15, 2026
@SomeoneToIgnore SomeoneToIgnore added the area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features label Mar 15, 2026
@maxdeviant maxdeviant changed the title fix claude agent model reset to default. agent_servers: Fix Claude Agent model resetting to default Mar 15, 2026
@zed-industries-bot
Copy link
Copy Markdown
Contributor

zed-industries-bot commented Mar 15, 2026

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 67c069d

@OmChillure
Copy link
Copy Markdown
Contributor Author

@esthertrapadoux can we add this to the guild , its solved !

Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril enabled auto-merge (squash) March 16, 2026 13:11
@esthertrapadoux esthertrapadoux moved this to Shipped by the Guild in Zed Guild - The Board Mar 16, 2026
auto-merge was automatically disabled March 16, 2026 13:30

Head branch was pushed to by a user without write access

@OmChillure
Copy link
Copy Markdown
Contributor Author

OmChillure commented Mar 16, 2026

Hello @Veykril , the tests faield due to check_style failed, added a fmt commit, auto merge was disabled would be great if you can merge again.

Thanks

@Veykril Veykril enabled auto-merge (squash) March 16, 2026 13:34
@Veykril Veykril merged commit 70a5669 into zed-industries:main Mar 16, 2026
29 checks passed
@zelenenka zelenenka added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Mar 16, 2026
@esthertrapadoux esthertrapadoux moved this to Shipped by the Guild in Zed Guild - The Board Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai Related to Agent Panel, Edit Prediction, Copilot, or other AI features cla-signed The user has signed the Contributor License Agreement guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

Status: Shipped by the Guild

Development

Successfully merging this pull request may close these issues.

Claude Agent: model reset to "Default (recommended)" when viewing history entries, ignoring user settings

6 participants