Fix Ayu Dark/Mirage dim terminal colors appearing as white#51462
Merged
danilo-leal merged 2 commits intozed-industries:mainfrom Mar 16, 2026
Merged
Conversation
Member
|
Heya, thanks for the PR! I think some other unrelated changes leaked through on it, though; mind cleaning those up? |
Closes zed-industries#46126 The dim terminal colors in Ayu Dark and Ayu Mirage were defined as light pastels (e.g. dim_red: #febab9) instead of muted/darker versions of the normal colors. On a dark background, the minimum contrast algorithm would boost these already-light colors toward white, making "dimmed" text appear brighter than normal text. This follows the same pattern used by Gruvbox and One Dark, where dim colors are ~70% brightness of the normal color (e.g. dim_red: #a74f53 from normal red: #ef7177). Ayu Light was already correct (its dim colors are darker, which is the correct direction for dimming on a light background).
d675036 to
24ed3f4
Compare
Contributor
Author
|
Cleaned up — rebased on main so only the ayu.json theme changes are included now. Sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #46126
Dim terminal colors in Ayu Dark and Ayu Mirage were defined as light pastels instead of muted/darker versions of the normal colors. On a dark background, the APCA minimum contrast algorithm boosted these already-light colors toward white, making "dimmed" text (e.g. zsh-autosuggestions) appear brighter than normal text.
Root cause
#0d1016(= background!)#85847f#febab9(light pink)#a74f53#d8eca8(light pastel)#769735#ffd9aa(light pastel)#b17d3aThe fix follows the same convention as Gruvbox and One Dark, where dim = ~70% brightness of the normal color.
Ayu Light was already correct (dim colors are darker, which is correct for light backgrounds).
Test plan
Release Notes: