gpui: Fix bottom-aligned scroll bar disappearing#51223
Merged
mikayla-maki merged 7 commits intozed-industries:mainfrom Mar 25, 2026
Merged
gpui: Fix bottom-aligned scroll bar disappearing#51223mikayla-maki merged 7 commits intozed-industries:mainfrom
mikayla-maki merged 7 commits intozed-industries:mainfrom
Conversation
Contributor
Author
|
Would love to talk to someone about this! the interaction here between gpui and zed itself has me a bit confused on if this change is necessary, if more changes should happen, if the code that prevents this behavior from occuring in zed should be changed or not, all has me a bit confused about what exactly the best course is. |
|
I happened to discover this bug while developing an app with gpui. I asked Codex to check whether it was my problem or an issue with gpui, and it quickly identified the cause. I then had it draft an issue. I didn’t expect the Zed team to fix it so quickly, and I hope this PR can be merged soon. |
406e8a1 to
672f53f
Compare
Contributor
Author
|
Cleaner Example Script: Details
|
mikayla-maki
requested changes
Mar 25, 2026
Contributor
Author
|
@mikayla-maki removed the comments, added the example to the pr and just named the values in the test. |
mikayla-maki
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51198
This actually doesn't effect any of the scrollbars in Zed, as they have a separate handler that prevents this issue from occurring
in
crates/ui/src/components/scrollbar.rs, line 856so it is gpui specific. I still added a test case and I have a manual test script:
Details
where I was able to test it out, here is a video of the new working behavior.
Screen.Recording.2026-03-10.at.3.48.15.PM.mov
Release Notes: