recent_projects: Don't panic when attempting to delete SSH server out of bounds#51091
Merged
recent_projects: Don't panic when attempting to delete SSH server out of bounds#51091
Conversation
… of bounds
Fixes ZED-517
Can be reproed by:
Going into server options of the last server on your list.
selecting "Remove server".
Clicking on the button AND issuing menu::Confirm action at the same time (well, roughly the same time).
The result: OS pop-up is issued twice; if the user does confirm twice, that's when that panic is hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ZED-517
Can be reproed by:
The result: OS pop-up is issued twice; if the user does confirm twice, that's when that panic is hit.
Closes #ISSUE
Before you mark this PR as ready for review, make sure that you have:
Release Notes: