Skip to content

Reuse existing bundled file editors#51053

Merged
yeskunall merged 2 commits intozed-industries:mainfrom
ishaksebsib:fix/default-settings-tab-reuse
Mar 8, 2026
Merged

Reuse existing bundled file editors#51053
yeskunall merged 2 commits intozed-industries:mainfrom
ishaksebsib:fix/default-settings-tab-reuse

Conversation

@ishaksebsib
Copy link
Copy Markdown
Contributor

Closes #46837

Reuse the existing read-only bundled editor when opening default settings or default key bindings again, instead of creating a duplicate tab each time.

Also adds a regression test covering repeated OpenDefaultSettings dispatches.

Before

2026-03-08.19-33-57.mp4

After

2026-03-08.19-31-27.mp4

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • Fixed default settings and default key bindings reopening duplicate tabs instead of reusing the existing tab.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 8, 2026
@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 8, 2026
@yeskunall yeskunall changed the title Reuse existing bundled settings editors Reuse existing bundled file editors Mar 8, 2026
@yeskunall
Copy link
Copy Markdown
Member

Thank you @ishaksebsib! Great QoL improvement and thanks @injust as always for reporting these weird issues/quirks! 💖

@yeskunall yeskunall merged commit 8762b7f into zed-industries:main Mar 8, 2026
39 checks passed
@ishaksebsib ishaksebsib deleted the fix/default-settings-tab-reuse branch March 9, 2026 05:15
@zelenenka zelenenka added the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keybind to open default keymap/settings file opens it multiple times instead of focusing the existing tab

3 participants