Skip to content

Disable the IME on Windows when text input is unexpected#51041

Merged
reflectronic merged 1 commit intomainfrom
windows-vim-ime
Mar 8, 2026
Merged

Disable the IME on Windows when text input is unexpected#51041
reflectronic merged 1 commit intomainfrom
windows-vim-ime

Conversation

@reflectronic
Copy link
Copy Markdown
Member

Fixes #42444

  • Changed accepts_text_input on the editor to be more precise. Previously, it returned true only in insert mode. Now it also returns true when an operator is pending.
  • On Windows, we disable the IME whenever there is no input handler which accepts_text_input.
    • How this improves Vim mode: in insert mode, the IME is enabled; in normal mode, it is disabled (command keys are not intercepted); when an operator is pending, the IME is re-enabled.

Release Notes:

  • On Windows, the IME is disabled in Vim normal and visual modes.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 8, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Mar 8, 2026
@reflectronic reflectronic enabled auto-merge (squash) March 8, 2026 04:50
@reflectronic reflectronic merged commit 4031db1 into main Mar 8, 2026
38 checks passed
@reflectronic reflectronic deleted the windows-vim-ime branch March 8, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: The issue of input method switching (not sure if it's a feature or a bug)

1 participant