Normalize line_comments strings to have a trailing space#51033
Merged
JosephTLyons merged 1 commit intozed-industries:mainfrom Mar 10, 2026
Merged
Normalize line_comments strings to have a trailing space#51033JosephTLyons merged 1 commit intozed-industries:mainfrom
line_comments strings to have a trailing space#51033JosephTLyons merged 1 commit intozed-industries:mainfrom
Conversation
line_comments strings to have a trailing space characterline_comments strings to have a trailing space
Contributor
Author
Collaborator
|
Thanks for this, @injust! |
JosephTLyons
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a search for
/^line_comments = .*[^\s\[]"/to identify these 3 languages:that don't add/remove a trailing space for inline comments. I couldn't find any indication that the absence of the trailing space is due to any peculiarity specific to these languages.
For Git Commit, I should note that (strictly speaking) the comment character is a single
#without a trailing space, as Git removes any line starting with the default comment character (#) (see https://git-scm.com/docs/git-config#Documentation/git-config.txt-corecommentChar).But I believe this change only affects whether
editor::ToggleCommentsadds/removes the space, and not how the file is syntax highlighted. So for aesthetics and consistency, it should be better to add/remove the trailing space.Before you mark this PR as ready for review, make sure that you have:
Release Notes: