keymap_editor: Remove redundant parentheses when displaying keymap context#50906
Merged
probably-neb merged 4 commits intozed-industries:mainfrom Mar 17, 2026
Conversation
Collaborator
|
This really cleans up the display in the keymap editor! Thanks for making this change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34976
Root Cause
The current implementation of
fmt::DisplayinKeyBindingContextPredicatehardcodes a parentheses aroundAndandOrcases. Causing the text displayed on the keymap editor to have nested parentheses.This PR refactors the display logic and make the parentheses added only when there's nested operator.
As is/ To be
Test coverage
Before you mark this PR as ready for review, make sure that you have:
Release Notes: