docs: Allow navigating search results with arrow keys#50901
Merged
gaauwe merged 3 commits intozed-industries:mainfrom Mar 11, 2026
Merged
docs: Allow navigating search results with arrow keys#50901gaauwe merged 3 commits intozed-industries:mainfrom
gaauwe merged 3 commits intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @implabinash on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
|
Thanks, this is indeed a nice improvement! I agree that it would be nice if the search bar stays fixed to the top when scrolling |
Contributor
Author
|
I updated the search bar style to fix it at the top while scrolling. |
Contributor
|
Made a few tweaks to have the scrollbar flush to the side but overall great update, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50604
before.mp4
after.mp4
Results:
Now, you can scroll the search results with the arrow keys.
Suggestion:
While this is working, I like to propose some better UX.
When you scroll with the arrow keys, the whole search results are scrolling along with the search bar. But, I think it would be better if we keep the search bar fixed on top and only the results scroll. Here is an example:
suggesting.mp4
If you think this will be better, please let me know, and I will update this PR.
Thank you.
Release Notes: