Fix crash in start_display_link (#50875) (cherry-pick to preview)#50878
Merged
zed-zippy[bot] merged 1 commit intov0.227.xfrom Mar 5, 2026
Merged
Fix crash in start_display_link (#50875) (cherry-pick to preview)#50878zed-zippy[bot] merged 1 commit intov0.227.xfrom
start_display_link (#50875) (cherry-pick to preview)#50878zed-zippy[bot] merged 1 commit intov0.227.xfrom
Conversation
Fixes ZED-5G8 If `DisplayLink::new` fails, `frame_requests` is dropped . It is not valid to destroy a DispatchSource that is not `resume()`d. So, ensure we call `resume()` before there's a chance for anything to fail. Release Notes: - Fixed a crash that could occur on macOS when changing monitor configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #50875 to preview
Fixes ZED-5G8
If
DisplayLink::newfails,frame_requestsis dropped . It is notvalid to destroy a DispatchSource that is not
resume()d. So, ensure wecall
resume()before there's a chance for anything to fail.Release Notes:
configurations