project_panel: Reveal in file manager when no entry is selected#50866
Merged
smitbarmase merged 1 commit intozed-industries:mainfrom Mar 10, 2026
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48284
Summary
project_panel::RevealInFileManagerwhen no project panel entry is selected.Root Cause
RevealInFileManagerpreviously depended onselected_sub_entry(). When selection is cleared (e.g. click project panel background), Command Palette dispatch had no target and no-op'd.Verification
cargo fmt --all -- --check./script/check-keymaps./script/clippy -p project_panelcargo test -p project_panel -- --nocaptureManual Testing
project_panel::RevealInFileManager) #48284.Project panel: Reveal in file managernow opens project root when selection is empty.Release Notes:
Project panel: Reveal in file managerto work even when no project panel entry is selected.