Skip to content

project_panel: Reveal in file manager when no entry is selected#50866

Merged
smitbarmase merged 1 commit intozed-industries:mainfrom
loadingalias:project-panel-reveal-in-file-manager-fallback
Mar 10, 2026
Merged

project_panel: Reveal in file manager when no entry is selected#50866
smitbarmase merged 1 commit intozed-industries:mainfrom
loadingalias:project-panel-reveal-in-file-manager-fallback

Conversation

@loadingalias
Copy link
Copy Markdown
Contributor

Closes #48284

Summary

  • Fix project_panel::RevealInFileManager when no project panel entry is selected.
  • Preserve existing selected entry behavior.
  • Add fallback to reveal the last visible worktree root when selection is empty.
  • Add regression test cov.

Root Cause

RevealInFileManager previously depended on selected_sub_entry(). When selection is cleared (e.g. click project panel background), Command Palette dispatch had no target and no-op'd.

Verification

  • cargo fmt --all -- --check
  • ./script/check-keymaps
  • ./script/clippy -p project_panel
  • cargo test -p project_panel -- --nocapture

Manual Testing

Release Notes:

  • Fixed Project panel: Reveal in file manager to work even when no project panel entry is selected.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 5, 2026
@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 5, 2026
@smitbarmase smitbarmase merged commit 8fa257b into zed-industries:main Mar 10, 2026
38 checks passed
@smitbarmase
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

Status: Shipped by the Guild

Development

Successfully merging this pull request may close these issues.

"Reveal in file explorer" command doesn't work (project_panel::RevealInFileManager)

3 participants