Fix parsing of filenames like main (1).log#50770
Fix parsing of filenames like main (1).log#50770Veykril merged 2 commits intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @hagz0r on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla_bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Just a gentle ping in case this got buried. |
crates/util/src/paths.rs
Outdated
| (?: | ||
| -\(\d+(?:[,:]\d+)?\) # filename:(row,column)-(row,column), filename:(row,column)-(row) | ||
| )? |
There was a problem hiding this comment.
This bit seems unnecessary / should not be part of this bug fix?
|
You were right, I applied the fix and waiting for your approval |
|
Thanks! |
Summary
Fixes Windows file-open parsing for names like
main (1).log.PathWithPosition::parse_strcould treat(1)in a normal filename as a position suffix and drop the extension/path tail. The regex is now anchored so parenthesized row/column parsing only applies at the end of the filename (with optional trailing:and optional range suffix).Testing
cargo test -p util path_with_position_parse_Closes #50597
Release Notes:
main (1).logon Windows.