picker: Prevent clicking non-selectable entries from confirming selection#50705
Conversation
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks, this looks like a good fix for the issue at hand.
I'd like if we could add a test for this behavior to ensure that this does not regress. Could you look into that?
Also, one thing that popped up while I looked at this is that we actually show a pointer cursor when hovering the element despite it not being clickable. Could I interest you into looking to fix that as well perhaps? Not insisting, just curious.
Of course, I will look to that now! |
@MrSubidubi, changes implemented as you requested. Follow bellow a showcase video testing the cursor pointer on the hover: |
MrSubidubi
left a comment
There was a problem hiding this comment.
Awesome work here and very much appreciate the work that went into the test. Thank you!
Appreciate your time invested, @MrSubidubi! |
Head branch was pushed to by a user without write access
|
@MrSubidubi , can you trigger the CI pipeline again? |
Closes #50627
Before you mark this PR as ready for review, make sure that you have:
Videos:
Before:
https://drive.google.com/file/d/1PahGhfx-wq9cyNqqMlctb9Np7M1Meo71/view?usp=sharing
After:
https://drive.google.com/file/d/135W6MQ9hKBurw5Z7YpHQQhoQwkh1NvUb/view?usp=sharing
Release Notes: