Fix terminal path click failing when path is prefixed with '0:'#50663
Merged
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom Mar 4, 2026
Merged
Conversation
…ndustries#50531) The path hyperlink regex's middle-char pattern [:(][^0-9()] allowed colon+space because space was not in the exclusion set. This caused '0: foo/bar.txt' to be matched as a single path instead of just 'foo/bar.txt'. Fix: add space to the exclusion class: [:(][^0-9()\\ ]
SomeoneToIgnore
approved these changes
Mar 4, 2026
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Looks good, thank you for the fix.
Just in case, I'll merge this after today's release to give this more time to be tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path hyperlink regex's middle-char pattern [:(][^0-9()] allowed colon+space because space was not in the exclusion set. This caused
0: foo/bar.txtto be matched as a single path instead of justfoo/bar.txt.Fix: add space to the exclusion class: [:(][^0-9()\\ ]
Closes #50531
Release Notes:
0:(Control-Clicking certain paths in the Terminal fails #50531)