Skip to content

editor: Hide hover links when mouse cursor is not visible#50424

Merged
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
nishanthkarthik:hover-hidden-cursor
Mar 6, 2026
Merged

editor: Hide hover links when mouse cursor is not visible#50424
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
nishanthkarthik:hover-hidden-cursor

Conversation

@nishanthkarthik
Copy link
Copy Markdown
Contributor

@nishanthkarthik nishanthkarthik commented Mar 1, 2026

When I am in the middle of editing, pressing Ctrl would counter-intuitively highlight links even when the mouse cursor is hidden. This change considers the state of the mouse cursor before painting links on hover.

Before: Modifier pressed, cursor hidden, link visible

image

After: Modifier pressed, cursor hidden (red dot indicates current cursor position)

image

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • Fixed spurious link highlighting when mouse cursor is hidden

Fixes #50776

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 1, 2026

We require contributors to sign our Contributor License Agreement, and we don't have @nishanthkarthik on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Mar 1, 2026
@nishanthkarthik
Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 1, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 1, 2026

The cla-bot has been summoned, and re-checked this pull request!

@MrSubidubi MrSubidubi changed the title editor: hide hover links when mouse cursor is not visible editor: Hide hover links when mouse cursor is not visible Mar 2, 2026
@SomeoneToIgnore SomeoneToIgnore self-assigned this Mar 6, 2026
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) March 6, 2026 07:45
@SomeoneToIgnore SomeoneToIgnore merged commit e9ffef0 into zed-industries:main Mar 6, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale link highlighting on hover

2 participants