Handle empty match list and do safe vector selection instead of slicing (#50232) (cherry-pick to stable)#50233
Merged
zed-zippy[bot] merged 1 commit intov0.225.xfrom Feb 26, 2026
Conversation
…ng (#50232) Handles a panic found in telemetry - when there are no template matches or feature matches, the picker delegate will panic due to an indexing exception. This solves by: 1. Returning early if there are no matches, and 2. Performing safe vector `get` operations instead of slicing, so we can handle a not-found scenario. https://github.com/user-attachments/assets/ac76164d-63aa-4e2b-8555-d8e4f4dd2524 Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Fixed potential crash from initializing devcontainer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #50232 to stable
Handles a panic found in telemetry - when there are no template matches
or feature matches, the picker delegate will panic due to an indexing
exception. This solves by:
getoperations instead of slicing, so we canhandle a not-found scenario.
Screen.Recording.2026-02-26.at.8.53.08.AM.mov
Before you mark this PR as ready for review, make sure that you have:
testing
aspects
checklist
Release Notes: