Skip to content

Fix terminal rename not working from context menu on inactive tabs#50031

Merged
Veykril merged 1 commit intozed-industries:mainfrom
razeghi71:fix/terminal-rename-inactive-tab
Mar 30, 2026
Merged

Fix terminal rename not working from context menu on inactive tabs#50031
Veykril merged 1 commit intozed-industries:mainfrom
razeghi71:fix/terminal-rename-inactive-tab

Conversation

@razeghi71
Copy link
Copy Markdown
Contributor

@razeghi71 razeghi71 commented Feb 24, 2026

Closes #49939

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
Screenshot 2026-02-24 at 11 53 57 PM
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • Fix terminal rename not working from context menu on inactive tabs

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 24, 2026
@zed-community-bot zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Feb 24, 2026
@mchisolm0
Copy link
Copy Markdown
Collaborator

mchisolm0 commented Mar 13, 2026

Thanks for taking the time to tackle this, @razeghi71! I did confirm that the bug is still present on nightly and that your PR fixes it.

Specs of Nightly with bug

Zed: v0.228.0+nightly.2272.2bd5c218552923ece73e5c7e9afccfa8877d904c (Zed Nightly 2bd5c21)
OS: Linux Wayland cachyos unknown
Memory: 15.5 GiB
Architecture: x86_64
GPU: NVIDIA GeForce RTX 3050 || NVIDIA || 590.48.01

Specs of dev build for this PR without the bug Zed: v0.226.0+dev.28e4415b9ebab48e4afd66819108fec3d2b86198 (Zed Dev 28e4415) (Taylor's Version) OS: Linux Wayland cachyos unknown Memory: 15.5 GiB Architecture: x86_64 GPU: NVIDIA GeForce RTX 3050 || NVIDIA || 590.48.01

@chenwuji2000-cyber
Copy link
Copy Markdown
Contributor

chenwuji2000-cyber commented Mar 29, 2026

same issue. need this. ❤️

Veykril
Veykril approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril merged commit ce7512b into zed-industries:main Mar 30, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

Assignees

@Veykril Veykril

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename action does not work when triggered from context menu on an unselected tab

4 participants

@razeghi71 @mchisolm0 @chenwuji2000-cyber @Veykril