Conversation
) Closes #49363 When an existing remote workspace's connection is dead (e.g. the server died and reconnect failed, leaving the client in `ServerNotRunning` state), `remote_connection()` returns `None`. Previously this caused an error dialog, blocking reconnection — the user had to manually switch to another project and back to recover. Now the code falls through to establish a fresh connection instead, matching the previous behavior where clicking "Reconnect" would just work. Release Notes: - Fixed remote reconnect failing with an error when the server is not running, now establishes a fresh connection instead.
af5920c to
7aa5a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #49834 to preview
Closes #49363
When an existing remote workspace's connection is dead (e.g. the server
died and reconnect failed, leaving the client in
ServerNotRunningstate),
remote_connection()returnsNone. Previously this caused anerror dialog, blocking reconnection — the user had to manually switch to
another project and back to recover.
Now the code falls through to establish a fresh connection instead,
matching the previous behavior where clicking "Reconnect" would just
work.
Release Notes:
running, now establishes a fresh connection instead.