Skip to content

lsp: Display readable gopls version in UI#49835

Merged
Veykril merged 2 commits intozed-industries:mainfrom
amtoaer:fix_gopls_version
Mar 17, 2026
Merged

lsp: Display readable gopls version in UI#49835
Veykril merged 2 commits intozed-industries:mainfrom
amtoaer:fix_gopls_version

Conversation

@amtoaer
Copy link
Copy Markdown
Contributor

@amtoaer amtoaer commented Feb 22, 2026

Closes #49757

Before After
CleanShot 2026-02-22 at 17 43 16@2x CleanShot 2026-02-22 at 17 42 21@2x

Before you mark this PR as ready for review, make sure that you have:

  • Added a solid test coverage and/or screenshots from doing manual testing
  • Done a self-review taking into account security and performance aspects
  • Aligned any UI changes with the UI checklist

Release Notes:

  • Fixed gopls version display showing raw JSON instead of readable version number

- Add `readable_version` to `LanguageServerStatus`
- Add `readable_version()` method to `LanguageServer` that parses JSON
  for gopls
- Use `readable_version` in LSP button UI for user-friendly display
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 22, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Feb 22, 2026
@yeskunall yeskunall self-assigned this Feb 23, 2026
@Veykril Veykril assigned Veykril and unassigned yeskunall Mar 17, 2026
Copy link
Copy Markdown
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of the location this is in, ideally this would live in the go module, but I am unsure how we can thread that best through, so I'll go ahead and merge this for now but if you have ideas there would love a follow up PR for that!

Thanks!

@Veykril Veykril merged commit 0895125 into zed-industries:main Mar 17, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory usage info for gopls LSP is not visible

4 participants