Skip to content

editor: Fix bracket highlight flickering when editing#49797

Merged
SomeoneToIgnore merged 3 commits intozed-industries:mainfrom
lingyaochu:quote_highlight
Feb 21, 2026
Merged

editor: Fix bracket highlight flickering when editing#49797
SomeoneToIgnore merged 3 commits intozed-industries:mainfrom
lingyaochu:quote_highlight

Conversation

@lingyaochu
Copy link
Contributor

Closes #49653

Before you mark this PR as ready for review, make sure that you have:

  • screen record added
  • Done a self-review taking into account security and performance aspects
  • No UI change

The original refresh_matching_bracket_highlights method always performed a clear --> highlight procedure, even when the bracket positions hadn't changed, causing the highlights to flicker. Normally, for single quotes or brackets, the flickering area is small and hard to notice (though visible if you pay close attention), but for Python docstrings, the three quotes create a larger highlighted area, making this issue much more apparent.

After fix:

2026-02-21.17-43-25.mp4

Release Notes:

  • Fixed bracket highlights flickering when editing inside brackets

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 21, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Feb 21, 2026
@SomeoneToIgnore SomeoneToIgnore self-assigned this Feb 21, 2026
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you.

@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) February 21, 2026 10:54
@SomeoneToIgnore SomeoneToIgnore merged commit c22eaa7 into zed-industries:main Feb 21, 2026
29 checks passed
@lingyaochu lingyaochu deleted the quote_highlight branch February 21, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docstrings flicker in Python

2 participants