Fix font weight in multiple elements#49539
Merged
Conversation
* Update the font weight used in the Agent Panel's editor to respect the `buffer_font_weight` setting. * Update the font weight used in the Command Palette to use the `ui_font_weight` setting value, seeing as the command palette is using the `ui_font` settings for the font family and features * Update the font weight used in the popovers to match the `buffer_font_weight`, as it's also using the buffer font family and features * Update the `LabelLike.buffer_font` method in order to correctly set the font weight, which fixes the font weight used in the file header when displaying a multibuffer editor * Update the font weight used in the markdown rendering for both code blocks and inline code to use the `buffer_font_weight` setting
df5252f to
9035c1b
Compare
Member
Author
|
For the screenshots below, a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer_font_weightsetting.ui_font_weightsetting value, seeing as the command palette is using theui_fontsettings for the font family and featuresbuffer_font_weight, as it's also using the buffer font family and featuresLabelLike.buffer_fontmethod in order to correctly set the font weight, which fixes the font weight used in the file header when displaying a multibuffer editorBefore you mark this PR as ready for review, make sure that you have:
Release Notes: