language_models: Activate StreamEnded support in completion streams for Cloud provider#49337
Merged
language_models: Activate StreamEnded support in completion streams for Cloud provider#49337
Conversation
Now that the cloud-side StreamEnded support has landed (CLO-263), enable it on the Zed client: - Send the `x-zed-client-supports-stream-ended-request-completion-status` header so cloud knows to send `StreamEnded` status events. - Track whether `StreamEnded` was received during the stream. - Emit `StreamEndedUnexpectedly` error when the stream closes without a `StreamEnded` status, indicating the response was truncated. Closes CLO-265, CLO-264, CLO-266
Contributor
Author
Something for the release notes? Or irrelevant internal implementation detail? edit: feels like release notes relevant, adding it. |
Member
|
@tomhoule We should be good to land this after releases roll tomorrow, so it will have a week to bake on Nightly. |
Contributor
Author
|
Sounds like a plan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the cloud-side StreamEnded support has landed, enable it on the Zed client:
x-zed-client-supports-stream-ended-request-completion-statusheader so cloud knows to sendStreamEndedstatus events.StreamEndedwas received during the stream.StreamEndedUnexpectedlyerror when the stream closes without aStreamEndedstatus, indicating the response was truncated.Concretely, this means that the agent panel will now display an abnormally terminated response stream for model calls through a Zed subscription as an error instead of just stopping.
Release Notes: