gpui: Take advantage of unified memory on macOS#49236
Merged
Anthony-Eid merged 22 commits intozed-industries:mainfrom Feb 21, 2026
Merged
gpui: Take advantage of unified memory on macOS#49236Anthony-Eid merged 22 commits intozed-industries:mainfrom
Anthony-Eid merged 22 commits intozed-industries:mainfrom
Conversation
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
Signed-off-by: Marco Mihai Condrache <52580954+marcocondrache@users.noreply.github.com>
5d1d01f to
10163aa
Compare
10163aa to
c4ec721
Compare
Contributor
|
This worked for me on my Intel Macbook (16inch 2019). |
Contributor
Is this still broken for you and are you able to use a preview version of Zed? |
Contributor
|
Hopefully this one is the final try! I'll merge this in after releases (in an hour) so the team has a week to see if it introduces any bugs |
Contributor
Author
|
@Anthony-Eid thank you so much! |
auto-merge was automatically disabled
February 19, 2026 20:05
Head branch was pushed to by a user without write access
Contributor
Author
|
@Anthony-Eid sorry, I forgot to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third attempt to land this improvement: (#45577, #44273)
The previous PR didn’t work on Intel MacBooks because I made a wrong assumption about the unified memory check.
has_unified_memoryonly tells us that the CPU and GPU share memory. It does not mean we’re running on an Apple GPU family.Memoryless textures are only supported on Apple GPUs. Some Intel Macs report unified memory, but they don’t support memoryless textures, which is why the previous change failed there.
So instead of relying on unified memory, we now explicitly check that we’re running on an Apple GPU family before enabling memoryless textures.
Before you mark this PR as ready for review, make sure that you have:
Release Notes: