language_models: Handle empty tool call arguments consistently#48958
Merged
benbrandt merged 1 commit intozed-industries:mainfrom Feb 12, 2026
Merged
language_models: Handle empty tool call arguments consistently#48958benbrandt merged 1 commit intozed-industries:mainfrom
benbrandt merged 1 commit intozed-industries:mainfrom
Conversation
0ec28eb to
bf7ad5d
Compare
benbrandt
approved these changes
Feb 12, 2026
Member
benbrandt
left a comment
There was a problem hiding this comment.
Thanks, seems like a nice change!
Normalize handling of empty tool call arguments across all LLM
providers.
Many providers return empty strings for tool calls with no arguments,
which would previously fail JSON parsing.
- Created shared parse_tool_arguments() helper in provider/util.rs that
treats empty strings as empty JSON objects ({})
- Refactored 10 occurrences across 9 provider files to use the helper
- Ensures consistent behavior across all providers (anthropic, bedrock,
copilot_chat, deepseek, lmstudio, mistral, open_ai, open_router)
Closes: zed-industries#48955
Release Notes:
- Fixed tool calls with no arguments failing when using certain LLM
providers
bf7ad5d to
8c0e134
Compare
Contributor
Author
Looking forward to use it in day to day life. I fixed the formatting/importing issues. Forgot to run fmt/clippy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize handling of empty tool call arguments across all LLM providers. Many providers return empty strings for tool calls with no arguments, which would previously fail JSON parsing.
Closes: #48955
Release Notes: