Skip to content

terminal: Fix Spawn Task and Agent terminal hangs on macOS#48877

Merged
smitbarmase merged 1 commit intomainfrom
fixing-terminal-hang-segsev
Feb 10, 2026
Merged

terminal: Fix Spawn Task and Agent terminal hangs on macOS#48877
smitbarmase merged 1 commit intomainfrom
fixing-terminal-hang-segsev

Conversation

@smitbarmase
Copy link
Member

@smitbarmase smitbarmase commented Feb 10, 2026

Follow-up to #47420 and #44193.

#47420 fixed child-exit status handling via upstream alacritty change (alacritty/alacritty#8825). However, stable/preview/nightly builds still reproduced hangs that dev builds did not.

The root cause matches #44193: spawned children inherit crash-handler Mach exception ports and hang. We already reset exception ports in util::command::new_smol_command and util::set_pre_exec_to_start_new_session, but PTY child spawning in alacritty_terminal was not covered.

This PR updates alacritty_terminal to include PTY pre_exec exception-port reset:
zed-industries/alacritty@9d9640d

Upstream:

Release Notes:

  • Fixed terminal tasks hanging on macOS when a spawned process is killed by a signal.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 10, 2026
@zed-community-bot zed-community-bot bot added the staff Pull requests authored by a current member of Zed staff label Feb 10, 2026
@smitbarmase smitbarmase merged commit 53a0075 into main Feb 10, 2026
52 of 54 checks passed
@smitbarmase smitbarmase deleted the fixing-terminal-hang-segsev branch February 10, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant