devcontainer: Fix project search returning no results on single-CPU containers#48798
Merged
osiewicz merged 1 commit intozed-industries:mainfrom Feb 9, 2026
Merged
Conversation
…ontainers When a devcontainer exposes only 1 CPU, the search worker pool was sized as `num_cpus - 1 = 0`, so zero workers were spawned. This caused all search channels to close immediately, producing zero results. File finder and LSP symbols were unaffected since they use different code paths. Ensure at least 1 worker is always spawned: `(num_cpus - 1).max(1)`.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47489
The search worker pool was sized as
num_cpus - 1, which spawned zero workers when a devcontainer exposed only 1 CPU. All search channels closed immediately and the search yielded zero results, while file finder and LSP symbols worked fine.The fix ensures at least 1 worker is always spawned:
(num_cpus - 1).max(1). Anum_cpusoverride onTestDispatcherand a new test reproduce the bug withserver_cx.executor().set_num_cpus(1).Manual testing
Add a
.devcontainer/directory to a new project with these files:Build zed and point it at the new project:
Open the built-in terminal, confirm
nprocprints1.Finally, run a project search (
Cmd+Shift+F) and search for contents that exist in it.Results should appear 🎉
Release Notes: