Skip to content

settings_ui: Fix tab navigation in edit predictions settings#48530

Merged
danilo-leal merged 1 commit intozed-industries:mainfrom
austincummings:fix-edit-prediction-settings-ui-tab-nav
Feb 5, 2026
Merged

settings_ui: Fix tab navigation in edit predictions settings#48530
danilo-leal merged 1 commit intozed-industries:mainfrom
austincummings:fix-edit-prediction-settings-ui-tab-nav

Conversation

@austincummings
Copy link
Contributor

The provider dropdown and GitHub Copilot sign-in button were not tab-navigable because they lacked tab_index. The copilot button conditionally sets tab_index only when edit_prediction is true, since it's also used in the agent configuration panel where tab navigation isn't used.

Closes #48391

Release Notes:

  • Fixed focus skipping provider dropdown and GitHub Copilot button in edit prediction settings

The provider dropdown and GitHub Copilot sign-in button were not
tab-navigable because they lacked tab_index. The copilot button
conditionally sets tab_index only when edit_prediction is true,
since it's also used in the agent configuration panel where tab
navigation isn't used.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 5, 2026
Copy link
Member

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙌

@danilo-leal danilo-leal enabled auto-merge (squash) February 5, 2026 21:53
@danilo-leal danilo-leal merged commit 5259b24 into zed-industries:main Feb 5, 2026
29 checks passed
@austincummings austincummings deleted the fix-edit-prediction-settings-ui-tab-nav branch February 5, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings UI focus moves to text field after using dropdown menu

2 participants