helix: Fix line select with empty first line#48026
Merged
kubkon merged 3 commits intozed-industries:mainfrom Feb 5, 2026
Merged
helix: Fix line select with empty first line#48026kubkon merged 3 commits intozed-industries:mainfrom
kubkon merged 3 commits intozed-industries:mainfrom
Conversation
c7ff962 to
7d05b4f
Compare
Co-authored-by: Lena Falk <lena@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
HelixSelectLinewith a pre-existing selection with an empty first line.An extra line is only needed if the selection is empty, so make that part of the condition.
Also added a test which fails before the fix to validate.
Closes #48023
Release Notes:
HelixSelectLinewith an empty first line and a pre-existing selection.