settings_ui: Fix editable project settings not being updated when a new workspace is created#47992
Merged
Anthony-Eid merged 3 commits intomainfrom Jan 30, 2026
Merged
Conversation
The bug occurred because `cx.observe_new::<Workspace>` would pass a mutable `Window` that was also the new workspace's window. Later, `fetch_files` would fail to read the newly created workspace from `WorkspaceStore` because its window already had a mutable reference to it. The fix always passes the Settings UI's window handle to the `fetch_files` function, and use a `settings_window_handle.defer` callback to call `fetch_files` after the newly created workspace's window no longer has any mutable references to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug occurred because
cx.observe_new::<Workspace>would pass amutable
Windowthat was also the new workspace's window. Later,fetch_fileswould fail to read the newly created workspace fromWorkspaceStorebecause its window already had a mutable reference toit.
The fix always passes the Settings UI's window handle to the
fetch_filesfunction, and uses asettings_window_handle.defercallback to call
fetch_filesafter the newly created workspace'swindow no longer has any mutable references to it.
Release Notes: