Fix missing directories in path prompt when show_hidden is enabled#47983
Merged
JosephTLyons merged 2 commits intomainfrom Jan 30, 2026
Merged
Conversation
When hidden_entries was true (set via .show_hidden()), max_id was never computed because it was only calculated inside the block that filters hidden files. This caused max_id to stay at 0. When the current directory entry is prepended to the list, it was assigned id: max_id + 1 = 1. However, entries already have sequential ids starting from 0, causing duplicate ids and missing entries in the list. Fix: compute max_id upfront from all entries before any filtering occurs.
5e4e093 to
ca6d98d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Select Toolchain Pathpicker would skip directories that exist on my system and displayopen this directorymultiple times.Personalis missing:Release Notes:
Select Toolchain Pathpath picker