Skip to content

Add back "fs: Replace MacWatcher with notify::FsEventWatcher""#47952

Merged
Anthony-Eid merged 1 commit intomainfrom
revert-47799-revert-47322-fs-mac-watcher-bye-bye
Jan 29, 2026
Merged

Add back "fs: Replace MacWatcher with notify::FsEventWatcher""#47952
Anthony-Eid merged 1 commit intomainfrom
revert-47799-revert-47322-fs-mac-watcher-bye-bye

Conversation

@Anthony-Eid
Copy link
Contributor

@Anthony-Eid Anthony-Eid commented Jan 29, 2026

Reverts #47799

Now that we have a week to let this be tested in Nightly we can merge it again

Note: Maybe in the future we can handle renames better as well. Right now if a root directory is renamed we don't change it's name in the registration, which would affect our filtering of what watches we should add

Release Notes:

  • Fix to many file descriptors error in MacOS

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 29, 2026
@Anthony-Eid Anthony-Eid enabled auto-merge (squash) January 29, 2026 17:11
@Anthony-Eid Anthony-Eid merged commit cd8a7b4 into main Jan 29, 2026
31 checks passed
@Anthony-Eid Anthony-Eid deleted the revert-47799-revert-47322-fs-mac-watcher-bye-bye branch January 29, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant