Skip to content

languages: Add highlighting for Go directives#47621

Merged
ConradIrwin merged 2 commits intozed-industries:mainfrom
ozacod:feat/go-highlighting-directive
Jan 28, 2026
Merged

languages: Add highlighting for Go directives#47621
ConradIrwin merged 2 commits intozed-industries:mainfrom
ozacod:feat/go-highlighting-directive

Conversation

@ozacod
Copy link
Contributor

@ozacod ozacod commented Jan 26, 2026

Closes #4381
Before:
before

After:
after

Release Notes:

  • Added highlighting for Go directives

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 26, 2026
@ConradIrwin
Copy link
Member

Nice! I like the idea of highlighting these, but I'm not sure about "attribute" (it might be right, but maybe there's something more specific). Did you consider other options?

@ozacod
Copy link
Contributor Author

ozacod commented Jan 27, 2026

Nice! I like the idea of highlighting these, but I'm not sure about "attribute" (it might be right, but maybe there's something more specific). Did you consider other options?

I think we can change it with @preproc, but I'm happy to go with a different option if you prefer.

@ConradIrwin
Copy link
Member

"preproc" sounds more right to me. Are there other languages with a similar feature, what do they use?.

Does preproc look better or worse in the default themes? Happy to ship something and adjust later as needed.

@ozacod
Copy link
Contributor Author

ozacod commented Jan 28, 2026

I implemented the change using preproc. Although the coloring didn't change for my dark theme, I think it’s distinct enough to avoid confusion, so I am not updating the PR description.

@ConradIrwin ConradIrwin enabled auto-merge (squash) January 28, 2026 21:07
@ConradIrwin
Copy link
Member

thanks

@ConradIrwin ConradIrwin merged commit 3e7f0ce into zed-industries:main Jan 28, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keywords in comments highlighting for Golang

2 participants