Ensure consistent newline behavior in auto-height editors with JetBrains keymap#47595
Conversation
9a595b1 to
247d1ad
Compare
247d1ad to
da28815
Compare
Veykril
left a comment
There was a problem hiding this comment.
Sorry for the late reply, I think this sounds like a good way to fix this, can we replicate this to the linux keymap as well (which will mirror it for windows too)
da28815 to
f5c7977
Compare
|
@Veykril thanks for the feedback. PR is updated with suggestions. |
|
@Veykril sorry for pining again and thanks for the review and approval. Is there anything I can do to to get this merged? Should be a low risk change with big improvement for some users (like me) who use the Jetbrains base keymap. |
|
Ah sorry, i thought this would merge after a workflow restart. I think you'll have to rebase on main for ci to unblock itself |
keymap Add an explicit `Editor && mode == auto_height` context block. This ensures that `Shift+Enter` and `Ctrl+Enter` correctly insert a newline at the cursor position in editors like the AI Agent Panel, preventing them from inheriting conflicting overrides (e.g., JetBrains mapping `Shift+Enter` to `editor::NewlineBelow`). Closes zed-industries#47269 Release Notes: - Fixed an issue where `Shift+Enter` would insert a newline at the end of the text instead of the cursor position in the Agent Panel when using certain keymaps.
f5c7977 to
6e08929
Compare
@Veykril did the rebase, but I think you need to approve the workflow run: |
Add an explicit
Editor && mode == auto_heightcontext block. This ensures thatShift+EnterandCtrl+Entercorrectly insert a newline at the cursor position in editors like the AI Agent Panel,preventing them from inheriting conflicting overrides (e.g., JetBrains mapping
Shift+Entertoeditor::NewlineBelow).Closes #47269
Release Notes:
Shift+Enterwould insert a newline at the end of the text instead of the cursor position in the Agent Panel when using certain keymaps.