image_viewer: Add pinch event support#47351
Open
MostlyKIGuess wants to merge 15 commits intozed-industries:mainfrom
Open
image_viewer: Add pinch event support#47351MostlyKIGuess wants to merge 15 commits intozed-industries:mainfrom
MostlyKIGuess wants to merge 15 commits intozed-industries:mainfrom
Conversation
- Add platform support for pinch gestures: - macOS: NSEventType::NSEventTypeMagnify - Wayland: zwp_pointer_gesture_pinch_v1 protocol
This comment was marked as off-topic.
This comment was marked as off-topic.
agu-z
requested changes
Feb 11, 2026
Contributor
agu-z
left a comment
There was a problem hiding this comment.
@MostlyKIGuess Thank you for your contribution. This is working well in my testing.
Before merging, I’d like to change the new GPUI methods to use [cfg(any(target_os = "linux", target_os = "macos"))] so consumers of the API are aware that this event isn’t available on Windows.
In the doc comments, we should also clarify that the event only works on macOS and Wayland, and explain how Windows simulates scroll wheel + Ctrl events on pinch.
In the future we may want to handle this complexity at the GPUI level, but I don’t think it’s a blocker as long as the API doesn’t suggest it should work when it won’t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements pinch / magnification gesture handling.
This uses the following wayland protocol. And the following API for mac.
Release Notes: