Skip to content

remote: Add configurable remote server cache retention (default 5)#47202

Merged
Veykril merged 4 commits intozed-industries:mainfrom
cppcoffee:remote
Jan 26, 2026
Merged

remote: Add configurable remote server cache retention (default 5)#47202
Veykril merged 4 commits intozed-industries:mainfrom
cppcoffee:remote

Conversation

@cppcoffee
Copy link
Contributor

Release Notes:

  • Improved add configurable remote server cache retention (default 5)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 20, 2026
@maxdeviant maxdeviant changed the title remote: add configurable remote server cache retention (default 5) remote: Add configurable remote server cache retention (default 5) Jan 20, 2026
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to have this configurable

@cppcoffee
Copy link
Contributor Author

cppcoffee commented Jan 21, 2026

I don't think we need to have this configurable

The zed config as follow:

  "ssh_connections": [
    {
      "host": "vm",
      "args": [],
      "projects": [
        ...
      ],
      "upload_binary_over_ssh": true,    # download to local
    },
  ],

Downloaded files will be stored locally and will not be deleted. Keep only 5 files(default value), delete the older ones, or is there a better way?

@Veykril
Copy link
Member

Veykril commented Jan 21, 2026

Yes we should just choose a default value here I think. No user will ever bother configuring this so a config is overkill.

@cppcoffee
Copy link
Contributor Author

Hi @Veykril , remove the configuration item, by default keep at most 5 remote server download packages

Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril enabled auto-merge (squash) January 26, 2026 07:13
@Veykril Veykril disabled auto-merge January 26, 2026 07:13
@Veykril Veykril enabled auto-merge (squash) January 26, 2026 07:14
@Veykril Veykril merged commit b397bd0 into zed-industries:main Jan 26, 2026
27 checks passed
@cppcoffee cppcoffee deleted the remote branch January 26, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants