file_finder: Remove project's root name from the file finder history#46957
file_finder: Remove project's root name from the file finder history#46957SomeoneToIgnore merged 11 commits intozed-industries:mainfrom
Conversation
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
I have tried adding a test (as every such logical thing needs one!) but then realized this is a wrong fix?
If I have 2 worktrees (directories) added, I want to have worktree prefix shown for history items either.
Otherwise, the search will show the prefix but the history items won't which looks very odd:
bad.mov
|
Does that also mean that if I have |
|
No, I think that's a valid case where we have to hide the prefixes. |
|
Alright I'll take a look at it in a few hours. |
|
With current changes it respects the project panel settings and hides the projects root based on the But even tho you said that the prefixes should also be hidden if there are more than one folders in the worktree, it kinda gets confusing, because even the |
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Right, good point, I also start to notice that after looking at
// Whether to hide the root entry when only one folder is open in the window.
documentation bit on the hide_root.
Fully agree: we should behave consistently (and have a test for it) + mention that file finder is also affected by this setting, in the default.json and wherever else (rustdocs?) so people are aware of all side-effects.
|
Made the changes. Happy to adjust further if needed. |
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Splendid, thank you so much.
Closes #45135
Since neither the project search nor file finder search was showing project's root name, including it in the history was unnecessary, especially when the user had
project_panel.hide_rootset totrue.Release Notes:
project_panel.hide_rootsettings