agent: Fix panic caused by polling ended stream#46839
Merged
rtfeldman merged 1 commit intozed-industries:mainfrom Jan 15, 2026
Merged
agent: Fix panic caused by polling ended stream#46839rtfeldman merged 1 commit intozed-industries:mainfrom
rtfeldman merged 1 commit intozed-industries:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE
Reproduction steps:
Following the stack trace we get to
Thread::run_turn_internal. I believe the panic happens in the following code which was introduced in #46802Both
Options get flattened, however the innerOptionrepresents the end of the stream, after which polling the stream using.next()will result in a panic.We could fix the logic in this particular spot, but I believe the simpler solution is to
.fuse()the stream, which stops the stream from panic'ing even after it has ended. This also prevents misuse in the future.The panic was introduces on main and did not land on a release yet, so no release notes.
Release Notes: