terminal: Fix IME position when cursor is hidden#46592
Merged
Veykril merged 1 commit intozed-industries:mainfrom Jan 12, 2026
Merged
terminal: Fix IME position when cursor is hidden#46592Veykril merged 1 commit intozed-industries:mainfrom
Veykril merged 1 commit intozed-industries:mainfrom
Conversation
Contributor
Author
|
Thanks for the quick review! The CI failure on test_open_paths appears to be a flaky test unrelated to this PR's changes. Would it be possible to re-run the failed job, or is there anything I can do on my end to help? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45553
Summary
When using applications that hide the terminal cursor (e.g., via ANSI escape sequence
\e[?25l), the IME candidate window appeared at the bottom-left of the screen, and the composition text was not displayed at all. This affects tools like Claude Code that hide the cursor during operation.The root cause was that cursor position calculation was skipped when the cursor shape was
Hidden. This fix separates cursor visibility from IME position calculation by always computing cursor bounds for IME positioning.Movies
Zed 0.218.6
Screen.Recording.2026-01-12.at.15.07.05.mov
With this fix
Screen.Recording.2026-01-12.at.15.15.45.mov
Release Notes: