Add action listener to workspace for pane::CloseActiveItem#46421
Merged
dinocosta merged 2 commits intozed-industries:mainfrom Jan 19, 2026
Conversation
Adds test for how the workspace handles the `pane::CloseActiveItem` action to close center pane items when focus is on a dock panel that doesn't contain a pane, for example, the project panel.
Member
|
Thanks @FloppyDisco ! I've pushed a small commit adding a test for these new changes. I wonder if having a dedicated, workspace-specific, action for this, like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45261
similar to #42588
this PR adds an action listener to the workspace that checks if the focus is currently on a dock that does not contain panes.
if that is true. it retrieves the active center pane from the workspace and closes the active item.
this improvement will allow users to set
cmd-wtopane::CloseActiveIteminstead ofworkspace::CloseActiveDockif that is the behavior they would prefer, which is also the typical behavior in most other editors.here is a video showing the center panes being closed while focus is on the Project Panel. and the panes in the Terminal Panel closing as normal.
closeActiveItem.mov
Release Notes:
pane::CloseActiveItemto close center pane items even when focus is on a dock panel like the project panel or outline panel