Allow Escape to interrupt agent thread from conversation focus#46410
Merged
Allow Escape to interrupt agent thread from conversation focus#46410
Conversation
- Add menu::Cancel action handler in AcpThreadView to call cancel_generation - Add tests for escape interrupting thread from both conversation and editor focus - Fix test-support feature propagation through rules_library -> title_bar -> recent_projects
2db0613 to
09c2c58
Compare
…ead-from-conversation
- Add cancel_count tracking to StubAgentConnection to verify server-side cancellation - Extract setup_generating_thread helper to reduce test code duplication - Add test_escape_when_idle_is_noop to verify escape doesn't cause issues when not generating - Both escape tests now verify the cancel was actually sent to the connection - Renamed tests to be clearer about what they're testing
…ead-from-conversation
Simplify the test changes by removing the server-side verification. The tests now just verify the UI behavior (thread status changing to Idle) which is sufficient for this feature.
|
Is there a way to go back to the previous system via the settings? I find it very annoying in vim mode that pressing escape cancel the agent work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When focus is on the conversation part of the agent panel (not the message editor), pressing Escape now interrupts the running thread. Previously, Escape only worked when the message editor had focus.
Release Notes: