Skip to content

Update pulldown-cmark to v0.13.0 to fix crash (#46267) (cherry-pick to stable)#46310

Merged
zed-zippy[bot] merged 1 commit intov0.218.xfrom
cherry-pick-v0.218.x-74c36083
Jan 8, 2026
Merged

Update pulldown-cmark to v0.13.0 to fix crash (#46267) (cherry-pick to stable)#46310
zed-zippy[bot] merged 1 commit intov0.218.xfrom
cherry-pick-v0.218.x-74c36083

Conversation

@zed-zippy
Copy link
Contributor

@zed-zippy zed-zippy bot commented Jan 8, 2026

Cherry-pick of #46267 to stable


Hi Zed team thank you for the awesome editor!

I recently stumbled upon a markdown sequence that seems to cause a crash

-	[	] -
\
-

*easier to read escape characters below

let crash_input = "-\t[\t] -\r\\\n-"
println!("{}", crash_input)

how to reproduce

  1. copy the markdown above
  2. save the file
  3. [shift] + [cmd] + p to open the command palette
  4. select markdown: open preview
  5. crash

I've confirmed that the issue is a bug in pulldown-cmark version 12, and
has been resolved in version
v0.13.0
and specifically fixed in
pulldown-cmark/pulldown-cmark#1017

this PR simply bumps the pulldown-cmark version in zed which resolves
the crash on my local machine.

recording

zedcrash.mp4

Release Notes:

  • Fixes crash due to markdown parsing via bumping pulldown-cmark

Hi Zed team thank you for the awesome editor!

I recently stumbled upon a markdown sequence that seems to cause a crash

```md
-	[	] -
\
-
```

*easier to read escape characters below

```rust
let crash_input = "-\t[\t] -\r\\\n-"
println!("{}", crash_input)
```

## how to reproduce

1. copy the markdown above
2. save the file
3. `[shift]` + `[cmd]` + `p` to open the command palette
4. select `markdown: open preview`
5. crash

I've confirmed that the issue is a bug in pulldown-cmark version 12, and
has been resolved in version
[v0.13.0](https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.13.0)
and specifically fixed in
pulldown-cmark/pulldown-cmark#1017

this PR simply bumps the pulldown-cmark version in zed which resolves
the crash on my local machine.


## recording 



https://github.com/user-attachments/assets/dc77132f-0d43-40f3-9841-0bf34fe714fb


Release Notes:

- Fixes crash due to markdown parsing via bumping pulldown-cmark
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 8, 2026
@zed-zippy zed-zippy bot merged commit ef05418 into v0.218.x Jan 8, 2026
23 checks passed
@zed-zippy zed-zippy bot deleted the cherry-pick-v0.218.x-74c36083 branch January 8, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant