Delete pulled diagnostics when the source registration is unregistered (#46105) (cherry-pick to preview)#46117
Merged
zed-zippy[bot] merged 1 commit intov0.218.xfrom Jan 5, 2026
Conversation
#46105) Additionally, fix a race condition where we'd still insert diagnostics from a document or workspace pull even if the registration had been unregistered in the time since the request was issued. And, as a bonus: when a new pull diagnostics registration is added, issue document pulls immediately. This should fix regressions with basedpyright caused by #43703. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #46105 to preview
Additionally, fix a race condition where we'd still insert diagnostics
from a document or workspace pull even if the registration had been
unregistered in the time since the request was issued.
And, as a bonus: when a new pull diagnostics registration is added,
issue document pulls immediately.
This should fix regressions with basedpyright caused by
#43703.
Release Notes: