languages: Highlight enumerator values as constants in C++#46115
languages: Highlight enumerator values as constants in C++#46115ozacod wants to merge 1 commit intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @ozacod on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
My only issue with this is that we probably can't do it consistently between definitions of the enumerator values and usages of those values. If this adds greater inconsistency, I tend to be against it. Thoughts @ozacod ? |
|
If enumerator value is not upper case, it would not be possible to highlight "Color:Red" without semantic understanding. This is probably not possible with tree sitter, requires lsp semantic tokens (Issue #7450). I agree, we should not implement it before related issue is solved. @maxbrunsfeld |
|
Yeah we will be adding semantic LSP-based highlighting in the near future, so maybe we should leave it as-is for now. |
Before:

After:
Release Notes: