Fix fs watchers not being removed#46036
Closed
AdamJedl wants to merge 4 commits intozed-industries:mainfrom
Closed
Fix fs watchers not being removed#46036AdamJedl wants to merge 4 commits intozed-industries:mainfrom
AdamJedl wants to merge 4 commits intozed-industries:mainfrom
Conversation
4758180 to
6f21743
Compare
This was referenced Jan 14, 2026
6f21743 to
58855b1
Compare
Collaborator
|
Hey @AdamJedl, thanks for trying to fix this, I'm going to merge #50412 as It's a bit simpler of a solution, and passes your tests as well. Separately - Thanks for your help linking all of the separate PRs that were made to fix the issue, I would have had no idea there were other PRs just looking at the one I was assigned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a folder is created then deleted and then created again it was logging "path to watch is already watched".
Edit the remove function in fs_watcher.rs so it removes all watchers in subfolders.
Added 2 tests
Should help #38109
Release Notes: