workspace: Fix closed pane items not reopening due to stale preview state#45286
Merged
smitbarmase merged 4 commits intozed-industries:mainfrom Jan 30, 2026
Merged
Conversation
Contributor
Author
|
Here's the before/after: screen-recording-reopen-closed-items.mov |
001eb3f to
4932255
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
smitbarmase
approved these changes
Jan 30, 2026
Member
smitbarmase
left a comment
There was a problem hiding this comment.
Thanks! I realized using a pane weak entity, we might not be able to update it since it's already in the pane update. This looks like a straightforward solution to fix it.
Removed is_preview field from ItemNavHistory as it becomes stale when a nav item becomes "permanent". This caused NavHistory::push to skip adding items to the closed_stack
a8ec86f to
40dbd86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45198
Release Notes: