Skip to content

Add telescope style search#44942

Closed
justsomelegs wants to merge 24 commits intozed-industries:mainfrom
justsomelegs:feat/telescope-search
Closed

Add telescope style search#44942
justsomelegs wants to merge 24 commits intozed-industries:mainfrom
justsomelegs:feat/telescope-search

Conversation

@justsomelegs
Copy link
Contributor

@justsomelegs justsomelegs commented Dec 16, 2025

Closes #8279

Release Notes:

  • Added Quick Search modal - a Telescope-inspired unified search with file finder, text grep, and commit search, featuring a live preview pane

A lot of work still to be done im sure on every front but just here so that input can be given, the feature tested and direction for this feature can hopefully be solidified

(per request tagging @yara-blue)

Ideas/Features:
  • File search
  • Project search with syntax and match highlighting
  • Git commit search with adjacent functionality to Git UI plus open commit instead of file
  • Open in split, or in commit view ( for commit mode )
  • Dismiss on focus loss
  • Full keyboard navigation
  • Git status shown on results throughout different search sources
  • Selected text copied to search on open
  • Quick preview git history on files via keybind/button
  • Toggle showing more LSP information if search term returns some (like hovering functions or methods)
  • LSP states visible whilst the modal is waiting for LSP startup or tasks to finish
  • Open in file manager keybinds
  • Copy path / Copy relative path keybinds with notifictions on doing so
  • Open buffer but keep modal focused (if you wanna open a few files at a time)
  • Search History
  • Finalise UI design
  • Decide on final keybinds
  • Decide on final settings (what can be adjusted)
Demo
Recording.2025-12-16.225009.mp4

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 16, 2025
@justsomelegs justsomelegs changed the title feat: telescope/quick_search implementation feature: telescope/quick_search implementation Dec 16, 2025
@justsomelegs justsomelegs changed the title feature: telescope/quick_search implementation feature to add a telescope style search implementation Dec 16, 2025
@justsomelegs justsomelegs changed the title feature to add a telescope style search implementation Feature to add a telescope style search implementation Dec 16, 2025
@justsomelegs
Copy link
Contributor Author

Note to anyone who checks this out
There is alot of stuff that just needs cleaning up from me moving it from being a part of the search crate to its own crate but i just wanted to get a draft PR up before i went to bed - its nothing i wont be able to clean up tomorrow :)

@justsomelegs justsomelegs mentioned this pull request Dec 16, 2025
1 task
@maxdeviant maxdeviant changed the title Feature to add a telescope style search implementation Add telescope style search Dec 16, 2025
@github-project-automation github-project-automation bot moved this to Community Champion PRs in Quality Week – December 2025 Dec 16, 2025
@franciskafyi franciskafyi moved this from Community Champion PRs to Community PRs in Quality Week – December 2025 Dec 16, 2025
@justsomelegs justsomelegs marked this pull request as ready for review December 16, 2025 23:10
@slavpetroff
Copy link

This is really great, thank you! One thing that is confusing right now is that tab and arrow keys navigate through the list of the findings. Isnt it better to be able to control by tab the category you are searching in? For instance tab could be used to cycle through the files, commits etc.. ? I think this is the default behaviour in Jetbrains as well, but could be wrong.

@justsomelegs
Copy link
Contributor Author

@slavpetroff thank you, think the end goal is to have both tab for category switching and maybe custom keybinds so you can open to the required one from launch

@justsomelegs
Copy link
Contributor Author

justsomelegs commented Dec 17, 2025

Update: started working on details footer that sources can populate in which ever way they choose.

For "grep" style search thinking of showing LSP info for valid symbols?

Screenshots image image

@justsomelegs
Copy link
Contributor Author

Just go LSP diagnostics implemented so that users are not left in dark when waiting for LSP info on the text_grep mode (project search)

image

@slavpetroff
Copy link

slavpetroff commented Dec 17, 2025

Thats really awesome! Another small thing i was thinking off, does it make sense for you to visually distinguish the sections in the find results between the results themselves and the files/places they are located? For instance darker background of the whole row where it displays the dropdown with the location in which the findings are grouped would help a lot to differentiate the findings from the places they are located at on first glance? Kind of similar how the exceprts are darker background when you search in find references for instance @justsomelegs

@justsomelegs
Copy link
Contributor Author

justsomelegs commented Dec 17, 2025

Update: Added footer to files that can be toggled.

image

@yara-blue
Copy link
Member

Hey @justsomelegs, we've been discussing this PR and #44530. Both are insane contributions. Its amazing and inspiring to see Zed become part of the community!

Its unfortunate we got two implementations for the same feature and now we have to choose. You put a ton of effort into this.

We have decided to go with the #44530, this PR at 10k lines has gotten too big to review and we like to introduce this feature slowly. We need some time to properly integrate it and get familiar with it. Once we've done so we'd love it if you with the community could slowly build it out.

Again thank you for all the effort you're putting into making Zed better.
Have a wonderful holidays and a happy new year!

@yara-blue yara-blue closed this Dec 18, 2025
@github-project-automation github-project-automation bot moved this from Community PRs to Done in Quality Week – December 2025 Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

Development

Successfully merging this pull request may close these issues.

Telescope-style search box

4 participants