You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To move towards latex support and eventual full jupyter notebook support, this PR adds basic svg mimetype support using the svg renderer.
Changes:
Added a temporary cargo patch to jupyter_protocol (see this for why, tldr: jupyter_protocol crate was seeing image/svg mimetype as image first, but handler for image/ prefix specifically did not handle svg mimetype and so all image/svg mimetypes would be parsed as an 'other')
added a SVGView similar to the ImageView foundation, which uses the svg_renderer to render svgs
Added output type and mimetype arm in outputs.rs to handle the svg mimetype (not possible without patch since svg would be parsed as an other)
We require contributors to sign our Contributor License Agreement, and we don't have @auriium2 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.
This PR includes links to the following GitHub Issues: #runtimed/runtimed#199
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.
Since we merged and shipped your work in the jupyter crates we should just bump the version of the jupyter packages here so you don't have to work around it.
@rgbkrk Sounds good to me, been buried in research/school/other crap but i'll eventually be back with some more latex related stuff as well. Thanks for the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area:replrepl, jupyter, notebooks, etccla-signedThe user has signed the Contributor License Agreement
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To move towards latex support and eventual full jupyter notebook support, this PR adds basic svg mimetype support using the svg renderer.
Changes:
Partially addresses:
Caveats:
Before:
After:
Release Notes: