Fix macros on x11 sometimes resulting in incorrect input#44234
Merged
probably-neb merged 12 commits intozed-industries:mainfrom Dec 16, 2025
Merged
Fix macros on x11 sometimes resulting in incorrect input#44234probably-neb merged 12 commits intozed-industries:mainfrom
probably-neb merged 12 commits intozed-industries:mainfrom
Conversation
Contributor
Author
|
Created a new PR with the experimental changes as discussed with @probably-neb |
aqrln
reviewed
Dec 6, 2025
Contributor
|
(disclaimer that I'm not from Zed team and know nothing about the code, just randomly opened the PR, I can't help with any follow up questions 😄) |
Contributor
Author
|
Thanks a lot @aqrln. I made the fixes. |
Contributor
Author
|
I've been using this for almost 2 weeks now. I haven't run into a single issue. I used mostly ZMK and a little bit of regular. Everything works perfectly. Is there anything I can do to help merge it? |
Collaborator
|
Tests seem to be flaking. Will merge once they pass. Thanks for the great work @AndreRoelofs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40678
The python file below simulates the macros at various timings and can be run by running:
sudo python3 -m pip install evdev --break-system-packagessudo python3 zed_shift_brace_replayer.pyChecked timings for hold=0.1, =0.01 and =0.001 with the latter two no longer causing incorrect inputs.
zed_shift_brace_replayer.py
Release Notes: