Skip to content

Add customization capabilities to which-key menu#43949

Closed
xipeng-jin wants to merge 7 commits intozed-industries:mainfrom
xipeng-jin:feature/which-key-custom-keybind-name
Closed

Add customization capabilities to which-key menu#43949
xipeng-jin wants to merge 7 commits intozed-industries:mainfrom
xipeng-jin:feature/which-key-custom-keybind-name

Conversation

@xipeng-jin
Copy link
Contributor

Closes #10910

Support parsing extra fields "binding_labels" and "group_labels" under each context stack in keymap.json

Release Notes:

  • Added customization capability to which-key menu to enabling renaming action name and prefix of the group of actions.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 1, 2025
@maxdeviant maxdeviant changed the title Add Customization Capabilities to Which-Key Menu Add customization capabilities to which-key menu Dec 1, 2025
@ConradIrwin
Copy link
Member

@xipeng-jin Thanks for the idea!

I don't think we should have the abstraction leak such that the whole code-base needs to know about the which-key feature; instead if we want to do customization we should put it in that crate.

That said, I don't think we need to do this at all. Zed already has the concept of "namespaces" for actions (vim::Blah, editor::Blah), and introducing another grouping that is orthogonal to that seems a bit confusing. (even :help g in Vim gives you "commands starting with 'g'").

@ConradIrwin ConradIrwin closed this Dec 4, 2025
@xipeng-jin
Copy link
Contributor Author

Hi @ConradIrwin , thanks for reminding me this. I truly agree we should not leak the abstraction layer and all features of which-key system should be put inside that crate. I also think this type of higher level customization might not be the priority to do right now. Lets leave it for the future reference. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Which-Key like menu

2 participants